Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics/librato: ensure resp.body closed #26969

Merged
merged 16 commits into from
Mar 27, 2023
Merged

metrics/librato: ensure resp.body closed #26969

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
fd13ea2
metrics/librato: ensure resp.body closed
jsvisa Mar 23, 2023
ffed346
rpc: ensure resp.body.close
jsvisa Mar 24, 2023
ea1c869
node: ensure rpc.body.close
jsvisa Mar 24, 2023
92e8f62
rpc: read body before close
jsvisa Mar 24, 2023
0a576ed
graphql: close resp.body
jsvisa Mar 24, 2023
651e69b
rpc,graphql: ioutil.Discard -> io.Discard
jsvisa Mar 24, 2023
b076048
p2p/simulation: ensure resp.body.close
jsvisa Mar 24, 2023
5a18dc5
node: register resp.body.close
jsvisa Mar 24, 2023
0fcf17b
Update p2p/simulations/adapters/exec.go
jsvisa Mar 24, 2023
94b997c
rpc: no need to read body
jsvisa Mar 24, 2023
2d12d25
Update graphql/graphql_test.go
jsvisa Mar 24, 2023
84c1506
Update graphql/graphql_test.go
jsvisa Mar 24, 2023
a3bb37b
Update graphql/graphql_test.go
jsvisa Mar 24, 2023
548835a
Update p2p/simulations/mocker_test.go
jsvisa Mar 24, 2023
b4ac27c
Update p2p/simulations/mocker_test.go
jsvisa Mar 24, 2023
34959e3
Update p2p/simulations/mocker_test.go
jsvisa Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rpc: ensure resp.body.close 
Signed-off-by: jsvisa <delweng@gmail.com>
  • Loading branch information
@jsvisa
jsvisa committed Mar 24, 2023
commit ffed3463a62b65d6217f4aa60142e6671bb559a8
1 change: 1 addition & 0 deletions rpc/http_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ func confirmHTTPRequestYieldsStatusCode(t *testing.T, method, contentType, body
if err != nil {
t.Fatalf("request failed: %v", err)
}
defer resp.Body.Close()
confirmStatusCode(t, resp.StatusCode, expectedStatusCode)
}

Expand Down