ci: disable coverage reporting in appveyor and travis

[holiman]

This PR is the XOR of #26672

I want to see if this makes the tests run any faster.

Also, got this error on a windows-build on appveyor: https://ci.appveyor.com/project/ethereum/go-ethereum/builds/46263355/job/0pm78r8hddm84kv5?fullLog=true#L807

consolecmd_test.go:60: have "password requirements not met: password too short (<10 characters)\nerror: coverage meta-data emit failed: writing C:\Users\appveyor\AppData\Local\Temp\1\go-build826161592\b564\gocoverdir\covmeta.c6c1f95b00265a2816b75dfdd6bd5f2e: rename from C:\Users\appveyor\AppData\Local\Temp\1\go-build826161592\b564\gocoverdir\tmp.covmeta.c6c1f95b00265a2816b75dfdd6bd5f2e1676638211275736200 failed: rename C:\Users\appveyor\AppData\Local\Temp\1\go-build826161592\b564\gocoverdir\tmp.covmeta.c6c1f95b00265a2816b75dfdd6bd5f2e1676638211275736200 C:\Users\appveyor\AppData\Local\Temp\1\go-build826161592\b564\gocoverdir\covmeta.c6c1f95b00265a2816b75dfdd6bd5f2e: Access is denied.\n\n", want "password requirements not met: password too short (<10 characters)\n"

Seems like the "reflected run of self" failed to emit coverage data, and caused a failure cascade.

[holiman]

This PR

Image: Ubuntu; Environment: GETH_ARCH=amd64, GETH_MINGW=C:\msys64\mingw64
Succeeded in 31 min 39 sec
Image: Visual Studio 2019; Environment: GETH_ARCH=amd64, GETH_MINGW=C:\msys64\mingw64
Succeeded in 37 min 57 sec
Image: Visual Studio 2019; Environment: GETH_ARCH=386, GETH_MINGW=C:\msys64\mingw32
Succeeded in 40 min 47 sec

Checking against some other successfull PRs in the recent history

Another PR https://ci.appveyor.com/project/ethereum/go-ethereum/builds/46262189:

Image: Ubuntu; Environment: GETH_ARCH=amd64, GETH_MINGW=C:\msys64\mingw64
Succeeded in 32 min 32 sec
Image: Visual Studio 2019; Environment: GETH_ARCH=amd64, GETH_MINGW=C:\msys64\mingw64
Succeeded in 43 min 4 sec
Image: Visual Studio 2019; Environment: GETH_ARCH=386, GETH_MINGW=C:\msys64\mingw32
Succeeded in 45 min 29 sec

a third PR https://ci.appveyor.com/project/ethereum/go-ethereum/builds/46260645

Image: Ubuntu; Environment: GETH_ARCH=amd64, GETH_MINGW=C:\msys64\mingw64
Succeeded in 33 min 54 sec
Image: Visual Studio 2019; Environment: GETH_ARCH=amd64, GETH_MINGW=C:\msys64\mingw64
Succeeded in 38 min 19 sec
Image: Visual Studio 2019; Environment: GETH_ARCH=386, GETH_MINGW=C:\msys64\mingw32
Succeeded in 42 min 27 sec

Fourth https://ci.appveyor.com/project/ethereum/go-ethereum/builds/46260583 :

Image: Ubuntu; Environment: GETH_ARCH=amd64, GETH_MINGW=C:\msys64\mingw64
Succeeded in 33 min 11 sec
Image: Visual Studio 2019; Environment: GETH_ARCH=amd64, GETH_MINGW=C:\msys64\mingw64
Succeeded in 38 min 21 sec
Image: Visual Studio 2019; Environment: GETH_ARCH=386, GETH_MINGW=C:\msys64\mingw32
Succeeded in 40 min 23 sec

---

Seems like it might be a bit faster, but the variance is pretty large anyway, so can't really say if it makes any difference.

[holiman]

That error happened here too: https://ci.appveyor.com/project/ethereum/go-ethereum/builds/46262225/job/wp6w2ov817ervtlg

[karalabe]

Myeah, I don't think this really matters, but why not get rid of unused stuff