Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC updates #263

Merged
merged 18 commits into from
Jan 30, 2015
Merged

RPC updates #263

merged 18 commits into from
Jan 30, 2015

Conversation

tgerring
Copy link
Contributor

Conversion to RPC over HTTP

@tgerring
Copy link
Contributor Author

Before merging, we should consider rolling in websocket functionality into the rpc package, since the messages and responses should be the same and only the transport is different.

@tgerring tgerring mentioned this pull request Jan 20, 2015
@kumavis
Copy link
Member

kumavis commented Jan 20, 2015

@tgerring yes this is what we're doing in node-ethereum, http + websocket protocol adapters to a generic rpc handler

@tgerring
Copy link
Contributor Author

Both traditional HTTP and Websockets should be supported via the updated rpc package. Both transport methods can be started separately as so: ethereum -rpc=true -rpcport=8080 -ws=true -wsport=40404

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.13% when pulling a38bca3 on jsonrpc into d792e95 on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.17% when pulling e9d017b on jsonrpc into d792e95 on develop.

@kumavis
Copy link
Member

kumavis commented Jan 28, 2015

Does the rpc via http handle CORS?

@tgerring
Copy link
Contributor Author

Is there a specific requirement in terms of enforcing or ignoring CORS? In the linked PR, neither HTTP nor Websocket respect the Origin header. Public-facing integrations will likely want to use a robust proxy such as Apache or Nginx to enforce rate-limiting, etc.

On Jan 27, 2015, at 8:32 PM, aaron notifications@github.com wrote:

Does the rpc via http handle CORS?


Reply to this email directly or view it on GitHub.

@kumavis
Copy link
Member

kumavis commented Jan 28, 2015

@tgerring the browser requires some additional headers for CORS Access-Control-Allow-Origin

@tgerring
Copy link
Contributor Author

@kumavis HTTP transport has been updated by @obscuren at 7f638f0 setting "Access-Control-Allow-Origin" to "*"

@obscuren obscuren merged commit 872b249 into develop Jan 30, 2015
@obscuren obscuren deleted the jsonrpc branch January 30, 2015 15:25
@kumavis
Copy link
Member

kumavis commented Jan 31, 2015

this is an awesome feature, but I suggest that it should be configurable and off by default, as it exposes the rpc to any website you visit.

@obscuren
Copy link
Contributor

obscuren commented Feb 1, 2015

The browser requires it. The browser is useless without. You can configure it (on/off, port). We could add a feature to (dis)allow CORS. Please open new issue.

ngtuna added a commit to ngtuna/tomochain that referenced this pull request Nov 10, 2018
…_Tx_randomize

reduce gas limit for Tx randomize
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Aug 13, 2021
tanishqjasoria pushed a commit to tanishqjasoria/go-ethereum that referenced this pull request Oct 31, 2023
…thereum#263)

* new deletion proof

* complete tracer and test

* extend proof for parallel tracing

* integrating into blocktrace

* lint

* deduplication of deletion proofs

* fix an issue on marking deletion

* fixs since last review

* Update version.go

---------

Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
Co-authored-by: Ubuntu <ubuntu@ip-10-2-9-63.us-west-2.compute.internal>
weiihann pushed a commit to weiihann/go-ethereum that referenced this pull request Nov 30, 2023
activate proof generation on fork  + remove code dups

use go-verkle's post-state API to verify proofs (ethereum#262)

use prague as the verkle activation fork (ethereum#263)

upgrade to latest go-ipa

activate verkle transition in "miner" (ethereum#265)

fix: do not force cancunTime upon verkle activation

workaround: do not use root translation in replay

workaround: deactivate overlay transition for now

fixes from trying to get the devnet to work (ethereum#267)

this line was left out from the previous commit

upgrade to go-verkle with fixed newvalue serialization

fix: ensure point cache isn't nil in copy (ethereum#268)

fix: dependency cycle in tests (ethereum#269)

upgrade to latest go-verkle

fix: write trie preimage data to db (ethereum#274)

fix: zero-root in produced block + sync (ethereum#275)

upgrade go-ipa

fix build

fix typo

include review feedback

add switch to add proofs to blocks (ethereum#278)

add fee recipient to witness (ethereum#279)

touch all fields in withdrawal account header (ethereum#277)
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this pull request Jan 4, 2024
Set TxRunMode for scheduled txs in DoCall
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Apr 29, 2024
…inary-signer

adding image signer when pushing images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants