accounts/keystore: replace inotify with fsnotify #26176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
approved these changes
Nov 14, 2022
This was referenced Jan 10, 2023
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 9, 2025
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 9, 2025
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 9, 2025
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 11, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26168
This PR replaces
github.com/rjeczalik/notifywithgithub.com/fsnotify/fsnotify, the latter seemingly more maintained.The latter also provides better granularity -- it would be possible to avoid large rescans, in cases where the user has thousands of files, and scans are slow. This PR doesn't change the behaviour, however, just tries to replace one with the other.
One thing that might we worth mentioning is that the old library was BYOC, bring-your-own-channel, meaning we could provide an event channel with some buffering. The new one doesn't have that.