Add export-history subcommand. #25325
Conversation
lightclient
force-pushed
the
export-history
branch
from
2c63079
to
616ca05
Compare
|
I rebased to |
cmd/utils/cmd.go
Outdated
| } | ||
|
|
||
| func ExportHistoryRange(bc *core.BlockChain, fn string, first uint64, last uint64, targetSize int) error { | ||
| var blocks []*spec.Block |
There was a problem hiding this comment.
We should define the block here to target the spec and not define externally.
There was a problem hiding this comment.
Hmm is there a reason to define another block type if we annotate types.Block here?
There was a problem hiding this comment.
We should define the block here to target the spec and not define externally.
Happy to move it here (maybe in its own package under cmd/utils) If you're ok with adding that here (along with all the go.mod dependency additions)
Hmm is there a reason to define another block type if we annotate types.Block here?
Back when I was defining that it seemed hard to do it all via just annotations on the existing geth structs, but I've paged out all the details 😬. Will take another look (maybe it is possible?) and report back.
| return ExportHistoryRange(bc, fn, uint64(0), bc.CurrentBlock().NumberU64(), targetSize) | ||
| } | ||
|
|
||
| func ExportHistoryRange(bc *core.BlockChain, fn string, first uint64, last uint64, targetSize int) error { |
There was a problem hiding this comment.
I think there should be verification that first+last < maxBlocks?
There was a problem hiding this comment.
🤔 what would maxBlocks be here?
geth export-history exports blocks and receipts in SSZ format.
henridf
force-pushed
the
export-history
branch
from
616ca05
to
f6ed864
Compare
henridf
requested review from
karalabe,
holiman and
rjl493456442
as code owners
|
@lightclient I moved the ssz definitions into the repo. Unfortunately right now annotating
|
|
Superseded by #26621 |
geth export-historyexports blocks and receipts in SSZ format.running todo:
bart)