all: remove version field #25096
Merged
all: remove version field #25096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
requested review from
fjl,
holiman,
zsfelfoldi,
rjl493456442,
s1na,
gballet and
karalabe
as code owners
|
Pls rebase 😬 |
lightclient
force-pushed
the
remove-version-field
branch
from
ef4a81d to
4ee625a
Compare
|
@karalabe sorry meant to open this as draft until the other PRs are merged. |
lightclient
force-pushed
the
remove-version-field
branch
from
4ee625a to
4d3dcf4
Compare
lightclient
force-pushed
the
remove-version-field
branch
from
4d3dcf4 to
0c6f81f
Compare
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Jul 14, 2022
all: remove version field
cp-wjhan
added a commit
to cp-yoonjin/go-wemix
that referenced
this pull request
Sep 26, 2023
all: remove version field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #25059
Remove the use of
rpc.API.Versionsince it is not subsequently used anywhere. It could be neat to eventually use this method to define methods likeeth_callV2or something, but that feels like far enough in the future (and uncertain enough) to deprecate the field for now.