eth/downloader: ignore zero size header batch for importing #24569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
Mar 22, 2022
rjl493456442
force-pushed
the
fix-ttd-border
branch
from
a94c2bd to
320e881
Compare
|
|
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Mar 23, 2022
…#24569) * eth/downloader: ignore zero size header batch for importing * core, light: reject empty header batch for importing
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
…#24569) * eth/downloader: ignore zero size header batch for importing * core, light: reject empty header batch for importing
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Sep 30, 2022
…#24569) * eth/downloader: ignore zero size header batch for importing * core, light: reject empty header batch for importing
cp-wjhan
pushed a commit
to cp-yoonjin/go-wemix
that referenced
this pull request
Nov 16, 2022
…#24569) * eth/downloader: ignore zero size header batch for importing * core, light: reject empty header batch for importing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a panic by importing zero size header batch. It can happen when the imported headers are crossing the ttd border and all the synced headers are post-merge.