Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/protocols/snap: avoid estimating infinite percentage #24529

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Mar 10, 2022

Fixes #24500

Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@karalabe karalabe added this to the 1.10.17 milestone Mar 11, 2022
@karalabe karalabe merged commit 1b58e42 into ethereum:master Mar 11, 2022
@karalabe
Copy link
Member

Now you just need to make a second fix that avoids estimating negative numbers when finishing :trollface:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snapsync progress show as +Inf%
3 participants