cmd/geth: rename --whitelist to --eth.requiredblocks #24505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanschneider
requested review from
karalabe,
holiman and
rjl493456442
as code owners
|
|
|
I agree that the peer prefix is new, but feel like requiredblocks by itself
still suffers some of the same issues as the old name: it’s still unclear
which subsystem requires these blocks from who. peerrequiredblocks (no dot
namespace) is very hard to parse especially with the double r.
I’m willing to move forward with requiredblocks though if others feel it’s
clear enough.
…On Sun, Mar 6, 2022 at 3:59 AM Felix Lange ***@***.***> wrote:
requiredblocks is a very good name. I don't really agree with the peer.
prefix because we don't have any other flag like that.
—
Reply to this email directly, view it on GitHub
<#24505 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAANCEFF5GNBMSLXGXTVO6TU6SMYNANCNFSM5P6R4HAA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I think it's good to have |
|
I just want something other than |
|
Yeah I'm fine with skipping the |
|
We have now settled on |
fjl
changed the title
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Mar 16, 2022
* cmd, eth: Rename whitelist argument to peer.requiredblocks * eth/ethconfig: document PeerRequiredBlocks better * cmd/utils: rename new flag to --eth.requiredblocks Co-authored-by: Felix Lange <fjl@twurst.com>
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
* cmd, eth: Rename whitelist argument to peer.requiredblocks * eth/ethconfig: document PeerRequiredBlocks better * cmd/utils: rename new flag to --eth.requiredblocks Co-authored-by: Felix Lange <fjl@twurst.com>
cp-wjhan
pushed a commit
to cp-yoonjin/go-wemix
that referenced
this pull request
Nov 16, 2022
* cmd, eth: Rename whitelist argument to peer.requiredblocks * eth/ethconfig: document PeerRequiredBlocks better * cmd/utils: rename new flag to --eth.requiredblocks Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For awhile now I've wanted to rename the "whitelist" option I introduced in #18028 to something both more descriptive (the current flag does not convey what is being whitelisted) and more inclusive.
IMO
--peer.requiredblocksis much more self-documenting, though I'm totally open to having a discussion around other argument names (and will make the required changes to this PR if we decide on a different name).