-
Notifications
You must be signed in to change notification settings - Fork 20.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accounts/abi/bind: improve WaitMined error handling #24321
Merged
fjl
merged 1 commit into
ethereum:master
from
komkom:improved_error_handling_for_wait_mined
Feb 1, 2022
Merged
accounts/abi/bind: improve WaitMined error handling #24321
fjl
merged 1 commit into
ethereum:master
from
komkom:improved_error_handling_for_wait_mined
Feb 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fjl
changed the title
accounts/abi: func WaitMined error handling improved
accounts/abi/bind: improve WaitMined error handling
Feb 1, 2022
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Feb 1, 2022
This change makes it so WaitMined no longer logs an error when the receipt is unavailable. It also changes the simulated backend to return NotFound for unavailable receipts, just like ethclient does.
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
This change makes it so WaitMined no longer logs an error when the receipt is unavailable. It also changes the simulated backend to return NotFound for unavailable receipts, just like ethclient does.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 8, 2025
This change makes it so WaitMined no longer logs an error when the receipt is unavailable. It also changes the simulated backend to return NotFound for unavailable receipts, just like ethclient does.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 8, 2025
This change makes it so WaitMined no longer logs an error when the receipt is unavailable. It also changes the simulated backend to return NotFound for unavailable receipts, just like ethclient does.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 8, 2025
This change makes it so WaitMined no longer logs an error when the receipt is unavailable. It also changes the simulated backend to return NotFound for unavailable receipts, just like ethclient does.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 9, 2025
This change makes it so WaitMined no longer logs an error when the receipt is unavailable. It also changes the simulated backend to return NotFound for unavailable receipts, just like ethclient does.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
This change makes it so WaitMined no longer logs an error when the receipt is unavailable. It also changes the simulated backend to return NotFound for unavailable receipts, just like ethclient does.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
This change makes it so WaitMined no longer logs an error when the receipt is unavailable. It also changes the simulated backend to return NotFound for unavailable receipts, just like ethclient does.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
This change makes it so WaitMined no longer logs an error when the receipt is unavailable. It also changes the simulated backend to return NotFound for unavailable receipts, just like ethclient does.
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
This change makes it so WaitMined no longer logs an error when the receipt is unavailable. It also changes the simulated backend to return NotFound for unavailable receipts, just like ethclient does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.