Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/rawdb: Enforce readonly in freezer instantiation #24119

Merged
merged 16 commits into from
Jan 18, 2022
Merged

core/rawdb: Enforce readonly in freezer instantiation #24119

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
63c9ce9
freezer: add readonly flag to table
s1na Dec 15, 2021
169e100
freezer: enforce readonly in table repair
s1na Dec 15, 2021
41f42bf
freezer: enforce readonly in newFreezer
s1na Dec 16, 2021
a5360a9
minor fix
s1na Dec 16, 2021
8f42a64
minor
s1na Dec 16, 2021
114a81e
core/rawdb: test that writing during readonly fails
holiman Jan 10, 2022
208c7a9
rm unused log
s1na Jan 10, 2022
2ddb5ec
check readonly on batch append
s1na Jan 11, 2022
d04392a
minor
s1na Jan 11, 2022
163dcbc
Revert "check readonly on batch append"
s1na Jan 11, 2022
e0e70f0
review fixes
s1na Jan 11, 2022
60dd843
minor test refactor
s1na Jan 11, 2022
b1aecc2
attempt at fixing windows issue
s1na Jan 11, 2022
0ad8cf8
add comment re windows sync issue
s1na Jan 11, 2022
6255ab1
k->kind
s1na Jan 11, 2022
803035b
open readonly db for genesis check
s1na Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
k->kind
  • Loading branch information
@s1na
s1na committed Jan 11, 2022
commit 6255ab196c37028ff5c8089016eea27e24ac4ae9
4 changes: 2 additions & 2 deletions core/rawdb/freezer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,10 +332,10 @@ func (f *freezer) validate() error {
break
}
// Now check every table against that length
for k, table := range f.tables {
for kind, table := range f.tables {
items := atomic.LoadUint64(&table.items)
if length != items {
return fmt.Errorf("freezer tables %s and %s have differing lengths: %d != %d", k, name, items, length)
return fmt.Errorf("freezer tables %s and %s have differing lengths: %d != %d", kind, name, items, length)
}
}
atomic.StoreUint64(&f.frozen, length)
Expand Down