core,eth,les: update unclean shutdown markers regularly #24077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
requested review from
holiman,
karalabe,
rjl493456442 and
zsfelfoldi
as code owners
eth/backend.go
Outdated
| func (s *Ethereum) updateUncleanShutdownMarkers() { | ||
| // update marker every five minutes | ||
| ticker := time.NewTicker(300 * time.Second) | ||
| defer func() { ticker.Stop() }() |
There was a problem hiding this comment.
you can simplify the code by defer ticker.Stop()
|
Updated based on the feedback I got on triage. |
|
Package name 'node' is not great because it conflicts with the existing top-level package name we already have. Maybe call it 'shutdowncheck' or something. It doesn't need to be a good/short name. |
|
I wanted to make it more general so we could put other modules in there too. But yeah the name conflict wasn't great. I renamed it. |
|
Updated based on standup discussion. I could've avoided |
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Dec 19, 2021
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
Fixes ethereum#22580 Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor to #22974, fixes #22580