Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts/abi/bind/backends: fix race condition in simulated backend #23898

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

joshuacolvin0
Copy link
Contributor

Now that SimulatedBackend.SuggestGasPrice inspects member values, a lock needs to be added to prevent a race condition.

Now that `SimulatedBackend.SuggestGasPrice` inspects member values, a lock needs to be added to prevent a race condition.
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman changed the title Fix race condition accounts/abi/bind: fix race condition in simulated backend Nov 12, 2021
@holiman holiman changed the title accounts/abi/bind: fix race condition in simulated backend accounts/abi/bind/backends: fix race condition in simulated backend Nov 12, 2021
@holiman holiman merged commit abc74a5 into ethereum:master Nov 12, 2021
@holiman holiman added this to the 1.10.13 milestone Nov 12, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Nov 12, 2021
…thereum#23898)

Now that `SimulatedBackend.SuggestGasPrice` inspects member values, a lock needs to be added to prevent a race condition.
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
…thereum#23898)

Now that `SimulatedBackend.SuggestGasPrice` inspects member values, a lock needs to be added to prevent a race condition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants