-
Notifications
You must be signed in to change notification settings - Fork 20.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/utils: add --nousb to the list of deprecated flags #23388
Conversation
this build will fail because I briefly have to delete nousb entirely
I hate this goimports error. There's nothing wrong with the syntax on that line, and yet it thinks there's a space where there's not. |
You should configure your editor to run gofmt or goimports on save. That's how all of us do it. You won't be able to manually fix these, Go is very strongly "formatted". The reason it's complaining is because there's a trailing tab (whitespace) after the |
alright, I've got my vscode configured to run gofmt now, so this commit should pass |
@karalabe alright, it passed on Travis, where it's required to pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Adds --nousb as a deprecated flag when someone runs the geth show-deprecated-flags command.
Adds --nousb as a deprecated flag when someone runs the geth show-deprecated-flags command.
This adds
--nousb
as a deprecated flag when someone runs thegeth show-deprecated-flags
command.