Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: fix stopping websocket rpc.Server #23211

Merged
merged 1 commit into from
Jul 15, 2021
Merged

node: fix stopping websocket rpc.Server #23211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
node/rpcstack.go 'doStop' gets wrong 'wsHandler'
  • Loading branch information
Evolution404 committed Jul 15, 2021
commit 257eb2fb3b02ba8dcfd5bb20a2d504f7c9b5829e
2 changes: 1 addition & 1 deletion node/rpcstack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ func (h *httpServer) doStop() {

// Shut down the server.
httpHandler := h.httpHandler.Load().(*rpcHandler)
wsHandler := h.httpHandler.Load().(*rpcHandler)
wsHandler := h.wsHandler.Load().(*rpcHandler)
if httpHandler != nil {
h.httpHandler.Store((*rpcHandler)(nil))
httpHandler.server.Stop()
Expand Down