Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/state/snapshot, ethdb: track deletions more accurately #22582

Merged
merged 3 commits into from
Mar 30, 2021
Merged

core/state/snapshot, ethdb: track deletions more accurately #22582

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd3440e
core/state/snapshot, ethdb: track deletions more accurately
karalabe Mar 26, 2021
091c2c7
core/state/snapshot: don't reset the iterator, leveldb's screwy
karalabe Mar 28, 2021
7977600
ethdb: don't mess with the insert batches for now
karalabe Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
core/state/snapshot: don't reset the iterator, leveldb's screwy
  • Loading branch information
@karalabe
karalabe committed Mar 30, 2021
commit 091c2c7895f93d6f75461b958c238b2d0dfb94d3
4 changes: 0 additions & 4 deletions core/state/snapshot/snapshot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,10 +494,6 @@ func diffToDisk(bottom *diffLayer) *diskLayer {
log.Crit("Failed to write storage deletions", "err", err)
}
batch.Reset()

// Recreate the iterator to allow LevelDB to compact the data away
it.Release()
it = rawdb.IterateStorageSnapshots(base.diskdb, hash) // Ok to recreate with same hash, old slots deleted
}
}
}
Expand Down