eth2: catalyst RPC calls and command line options #22468
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
force-pushed
the
cacatalyst-for-executable-beacon-chain-rebased
branch
3 times, most recently
from
f409a01 to
7b9fe46
Compare
…ructions Co-Authored-By: Mikhail Kalinin <noblesse.knight@gmail.com>
gballet
force-pushed
the
cacatalyst-for-executable-beacon-chain-rebased
branch
3 times, most recently
from
2cd97ee to
27f37ed
Compare
rjl493456442
reviewed
Apr 9, 2021
| } | ||
| } | ||
|
|
||
| block, err := api.eth.Engine().FinalizeAndAssemble(bc, header, api.env.state, transactions, nil /* uncles */, api.env.receipts) |
There was a problem hiding this comment.
QQ: the block reward is applied based on the ethash rules. So in the eth2, actually there is no block reward here right? The reward will be applied in the consensus layer(they have their own accounting model).
There was a problem hiding this comment.
Yes, this is the long term view. Right after the merge, you won't be able to move the "eth2 eth" from the beacon chain into the eth1 "execution layer", so it still makes sense to offer a reward... more importantly, for the upcoming testnet: if you don't have a way to produce value, you won't be able to test anything.
gballet
force-pushed
the
cacatalyst-for-executable-beacon-chain-rebased
branch
from
27f37ed to
523f1cb
Compare
gballet
force-pushed
the
cacatalyst-for-executable-beacon-chain-rebased
branch
from
523f1cb to
9a35a22
Compare
gballet
commented
Apr 9, 2021
| ) | ||
|
|
||
| // JumpTable contains the EVM opcodes supported at a given fork. | ||
| type JumpTable [256]*operation | ||
|
|
||
| //nolint:deadcode |
There was a problem hiding this comment.
node to self: this is no longer needed
|
Closing to prevent confusion with #22641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #22320