Update cpu_syscall.go #22262
Merged
Update cpu_syscall.go #22262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERROR REMEDY: src/github.com/ethereum/go-ethereum/metrics/cpu_syscall.go:34:47: invalid operation: (usage.Utime.Sec + usage.Stime.Sec) * 100 + int64(usage.Utime.Usec + usage.Stime.Usec) / 10000 (mismatched types int32 and int64)
MariusVanDerWijden
approved these changes
Feb 8, 2021
Member
MariusVanDerWijden
left a comment
MariusVanDerWijden
left a comment
There was a problem hiding this comment.
LGTM, reverts a regression introduced in #21921
renaynay
pushed a commit
to renaynay/go-ethereum
that referenced
this pull request
Feb 9, 2021
fixes an regression which caused build failure on certain platforms
renaynay
pushed a commit
to renaynay/go-ethereum
that referenced
this pull request
Feb 16, 2021
fixes an regression which caused build failure on certain platforms
9 tasks
9 tasks
This was referenced Sep 23, 2022
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 13, 2024
fixes an regression which caused build failure on certain platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MINOR ERROR with go1.15: src/github.com/ethereum/go-ethereum/metrics/cpu_syscall.go:34:47: invalid operation: (usage.Utime.Sec + usage.Stime.Sec) * 100 + int64(usage.Utime.Usec + usage.Stime.Usec) / 10000 (mismatched types int32 and int64)