tests/fuzzers/abi: better test generation #22158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
Jan 11, 2021
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
LGTM. We'll notice if it starts failing on oss-fuzz, it's not a biggie to fix it later if so
bulgakovk
pushed a commit
to bulgakovk/go-ethereum
that referenced
this pull request
Jan 26, 2021
* tests/fuzzers/abi: better test generation * tests/fuzzers/abi: fixed packing issue * oss-fuzz: enable abi fuzzer
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the fuzzers
It decreases a bit the ability of the fuzzers to test everything, since the
Pack(Unpack(in)) == intest was removed. However this test would often fail if the ABI only had a single argument, eg.0x123...890would be unpacked to0x0000...0090if the ABI only specifies a singleuint8argument, therefore the packing step could never recreatein.The PR also reenables the abi fuzzer for oss-fuzz (it was disabled since it created so many errors)
@holiman If you think it is to early to put it on oss-fuzz we can also drop the last commit
ed4865f