cmd/geth: usb is off by default #21984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
Dec 11, 2020
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
Functionality-wise, this PR LGTM. I personally don't really mind the way it works as-is though
Closed
fjl
approved these changes
Jan 5, 2021
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during standup, this PR turns USB off by default and deprecates
--nousb. It introduces the inverse option--usb.The goal of this PR is to initiate a removal of the account system from geth and move it into clef, as well as reduce the reliance of geth on C dependencies.