Fixed ineffectual assignments #19869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed assigning values to variables we don't end up using.
muesli
requested review from
gballet,
holiman,
janos,
karalabe,
nonsense,
rjl493456442 and
zelig
as code owners
karalabe
reviewed
Jul 22, 2019
| @@ -416,7 +416,7 @@ func startExecNodeStack() (*node.Node, error) { | |||
| } | |||
|
|
|||
| // create enode record | |||
| nodeTcpConn, err := net.ResolveTCPAddr("tcp", conf.Stack.P2P.ListenAddr) | |||
| nodeTcpConn, _ := net.ResolveTCPAddr("tcp", conf.Stack.P2P.ListenAddr) | |||
karalabe
reviewed
Jul 22, 2019
| @@ -130,7 +130,7 @@ func (peer *Peer) handshake() error { | |||
| } | |||
| } | |||
|
|
|||
| isRemotePeerLightNode, err := s.Bool() | |||
| isRemotePeerLightNode, _ := s.Bool() | |||
There was a problem hiding this comment.
Shouldn't we rather handle this, than ignore? Ping @gballet
There was a problem hiding this comment.
this is a feature required by status, I don't think Parity has it. So if that field is not present, then isRemotePeerLightNode == false should be assumed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed assigning values to variables we don't end up using.