Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: implement simple checkpoint syncing #19543

Merged
merged 11 commits into from
Jun 28, 2019
Merged

all: implement simple checkpoint syncing #19543

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
75a2172
all: implement simple checkpoint syncing
rjl493456442 Sep 20, 2018
7ca0916
cmd/registrar, contracts/registrar: fix lints
rjl493456442 Jun 7, 2019
d6266a5
accounts/abi/bind, les: address comments
rjl493456442 Jun 11, 2019
2f66fee
cmd, contracts, les, light, params: minor checkpoint sync cleanups
karalabe Jun 14, 2019
1e51c9a
cmd, eth, les, light: move checkpoint config to config file
rjl493456442 Jun 24, 2019
75be697
cmd, eth, les, params: address comments
rjl493456442 Jun 25, 2019
3525d60
eth, les, params: address comments
rjl493456442 Jun 25, 2019
aa2697f
cmd: polish up the checkpoint admin CLI
karalabe Jun 26, 2019
54ba20a
cmd, contracts, params: deploy new version contract
rjl493456442 Jun 26, 2019
457c98c
cmd/checkpoint-admin: add another flag for clef mode signing
rjl493456442 Jun 26, 2019
d08732b
cmd, contracts, les: rename and regen checkpoint oracle with abigen
karalabe Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cmd/registrar, contracts/registrar: fix lints
  • Loading branch information
@rjl493456442 @karalabe
rjl493456442 authored and karalabe committed Jun 26, 2019
commit 7ca0916ab902692c9a449c115ce4b2c741b56e80
5 changes: 1 addition & 4 deletions cmd/registrar/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,10 +262,7 @@ func registerCheckpoint(ctx *cli.Context) error {
}
sigStrs := strings.Split(ctx.GlobalString(signatureFlag.Name), ",")
for _, sig := range sigStrs {
trimmed := strings.TrimSpace(sig)
if strings.HasPrefix(trimmed, "0x") {
trimmed = trimmed[2:]
}
trimmed := strings.TrimPrefix(strings.TrimSpace(sig), "0x")
if len(trimmed) != 130 {
utils.Fatalf("Invalid signature in --signature: %s", trimmed)
} else {
Expand Down
4 changes: 2 additions & 2 deletions contracts/registrar/registrar_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func assertSignature(addr common.Address, index uint64, hash [32]byte, r, s [32]
}
var signer common.Address
copy(signer[:], crypto.Keccak256(pubkey[1:])[12:])
return bytes.Compare(signer.Bytes(), expect.Bytes()) == 0
return bytes.Equal(signer.Bytes(), expect.Bytes())
}

type Account struct {
Expand Down Expand Up @@ -213,7 +213,7 @@ func TestCheckpointRegister(t *testing.T) {
if lindex != index {
return errors.New("latest checkpoint index mismatch")
}
if bytes.Compare(lhash[:], hash[:]) != 0 {
if !bytes.Equal(lhash[:], hash[:]) {
return errors.New("latest checkpoint hash mismatch")
}
if lheight.Cmp(height) != 0 {
Expand Down