-
Notifications
You must be signed in to change notification settings - Fork 20.8k
Swarm swap accounting phase 1 #17901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opened too early. Superseded by ethersphere/swarm#962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the first phase of swap accounting for swarm message exchange.
This current implementation only does the accounting part, no cryptoeconomic features are implemented yet (price negotiation, claim settling, etc.). This means this implementation just keeps track of how many units are exchanged between nodes and maintains a balance with them.
The currently only accounted protocol is swarm's streaming protocol (
swarm/network/stream
). The prices defined in that protocol are totally arbitrary and will require monitoring, simulations and analysis before they can be seriously taken into account.Basic design:
p2p/protocols/accounting.go
defines the basic interfaces:Balance
defines the actual accounting interface. It only has anAdd
function. This function will be called with a peer instance and an amount. If the amount is negative, then the local node is being debited, if it is positive, the local node is being credited.Prices
is an interface that defines how prices are being expected. Every accounted protocol should provide an implementation, and return aPrice
structure for every message for which it requires accounting. This struct contains aValue int64
field; negative means receiver pays, positive means the sender pays for the message.An accounted protocol needs to provide a
Hook
inside itsSpec
, where it defines its messages. TheHook
contains aBalance
and aPrices
interfaces, which allows the messaging infrastructure to transparently do the accounting.