internal/debug: support color terminal for cygwin/msys2 #17740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackmod
force-pushed
the
cygwin-fixes
branch
from
aaa8f63
to
686533b
Compare
fjl
reviewed
Sep 28, 2018
fjl
changed the title
|
Please remove the change in package node for now. We can make it in a separate PR. |
hackmod
force-pushed
the
cygwin-fixes
branch
from
686533b
to
cbec267
Compare
hackmod
force-pushed
the
cygwin-fixes
branch
from
cbec267
to
4caad4d
Compare
|
can you provide some insight on why building for ppc64 and ppc64le was disabled for vendor/github.com/mattn/go-isatty/isatty_linux.go module? |
|
@mksully22 oops! some files are missing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed color terminal support for cygwin/msys2
go-isattyinstead oflog/termand removelog/termpackagefixed default data path issue under cygwin/msys2
APPDATAenv variable for windows