Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounts/keystore: rename skipKeyFile to nonKeyFile to better rev… #17290

Merged
merged 1 commit into from
Aug 3, 2018
Merged

accounts/keystore: rename skipKeyFile to nonKeyFile to better rev… #17290

merged 1 commit into from
Aug 3, 2018

Conversation

rociiu
Copy link
Contributor

@rociiu rociiu commented Jul 31, 2018 •
edited
Loading

Refactor: rename skipKeyFile to nonKeyFile to better reveal it's purpose to avoid confusion.

@karalabe
Copy link
Member

karalabe commented Aug 3, 2018

Good catch, though I think skipNonKeyFile is not the best name either because it really doesn't "skip" anything, it just returns true/false. Perhaps lets call it nonKeyFile. Then the if nonKeyFile(fi) conditions are meaningful.

@karalabe karalabe added this to the 1.8.14 milestone Aug 3, 2018
@rociiu rociiu force-pushed the accounts_keystore_file_cache_refactor branch from a931b85 to be32017 Compare August 3, 2018 06:49
@rociiu rociiu changed the title accounts/keystore: rename skipKeyFile to skipNonKeyFile to better rev… accounts/keystore: rename skipKeyFile to nonKeyFile to better rev… Aug 3, 2018
@rociiu
Copy link
Contributor Author

rociiu commented Aug 3, 2018

Make sense to me, changed it to nonKeyFile. Thanks!

karalabe
karalabe approved these changes Aug 3, 2018
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@karalabe karalabe merged commit 70176cd into ethereum:master Aug 3, 2018
acud referenced this pull request in ethersphere/swarm Aug 6, 2018
@rociiu @acud
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
b3229d5 
…the function purpose (#17290)
firmianavan pushed a commit to firmianavan/go-ethereum that referenced this pull request Aug 28, 2018
@rociiu @firmianavan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
6e90196 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 27, 2024
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
0488313 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 27, 2024
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
bcdb3ef 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 27, 2024
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
9c08e8f 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 27, 2024
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
86391a5 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 27, 2024
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
60138be 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 27, 2024
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
e7ff000 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 28, 2024
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
a9c4b06 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 30, 2024
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
a399eee 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 30, 2024
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
62bab6e 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 30, 2024
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
96f719b 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 30, 2024
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
eb254ac 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 1, 2025
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
2d4142c 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 3, 2025
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
99166ef 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 4, 2025
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
ca92948 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 6, 2025
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
f5e1b17 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
b3662ec 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
3fa7436 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 14, 2025
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
01497c4 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 16, 2025
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
310a24e 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 17, 2025
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
fdaf483 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 22, 2025
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
97ff077 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 22, 2025
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
9678a3a 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 23, 2025
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
5dd29f2 
…the function purpose (ethereum#17290)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 24, 2025
@gzliudan
accounts/keystore: rename skipKeyFile to nonKeyFile to better reveal …
165510d 
…the function purpose (ethereum#17290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.14
Development

Successfully merging this pull request may close these issues.
2 participants
@rociiu @karalabe