cmd, dashboard, internal, log, node: logging feature #17097
Conversation
log/handler.go
Outdated
log/handler.go
Outdated
log/handler.go
Outdated
There was a problem hiding this comment.
Let's restrict the permissions to 0700, since we don't really want everyone on the machine reading our logs.
log/handler.go
Outdated
There was a problem hiding this comment.
Let's return an error instead, panics can turn nasty if deep enough in the code. Same for all other panics too in this method btw.
log/handler.go
Outdated
dashboard/log.go
Outdated
dashboard/log.go
Outdated
dashboard/log.go
Outdated
There was a problem hiding this comment.
separate it out as emptyChunk.
dashboard/assets/components/Logs.jsx
Outdated
There was a problem hiding this comment.
Let's use new Date(t) and handle any errors, cleaner than string manipulation.
dashboard/assets/components/Logs.jsx
Outdated
There was a problem hiding this comment.
nitpick, use val, same length as key.
dashboard/assets/components/Logs.jsx
Outdated
|
You need to vendor in the missing packages. Also, afaik we already have a file system notification package vendored in. Perhaps use that instead? |
|
You also need to |
kurkomisi
force-pushed
the
dashboard-logger
branch
from
ab025a5 to
64af3ef
Compare
There was a problem hiding this comment.
Something seems off, I'm getting errors in the logs when I load the page.
WARN [07-09|12:01:34.919] Failed to load the asset path=/service-worker-7c7a96ce6fa87adc81b6af59edceb61b59781902a923313485bf6f4d32a1fad3.js err="Asset service-worker-7c7a96ce6fa87adc81b6af59edceb61b59781902a923313485bf6f4d32a1fad3.js not found"
* cmd, dashboard, internal, log, node: logging feature * cmd, dashboard, internal, log: requested changes * dashboard, vendor: gofmt, govendor, use vendored file watcher * dashboard, log: gofmt -s -w, goimports * dashboard, log: gosimple
2 participants
This PR contains an implementation of log saver and visualizer.