cmd, dashboard, internal, log, node: logging feature #17097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
requested changes
Jun 28, 2018
log/handler.go
Outdated
| @@ -70,6 +74,103 @@ func FileHandler(path string, fmtr Format) (Handler, error) { | |||
| return closingHandler{f, StreamHandler(f, fmtr)}, nil | |||
| } | |||
|
|
|||
| type writeCounter struct { | |||
log/handler.go
Outdated
| count uint | ||
| } | ||
|
|
||
| func (w *writeCounter) Write(p []byte) (n int, err error) { |
log/handler.go
Outdated
| // at the given path. When a file's size reaches the limit, the handler creates | ||
| // a new file named after the timestamp of the first log record it will contain. | ||
| func RotatingFileHandler(path string, limit uint, formatter Format) Handler { | ||
| if err := os.MkdirAll(path, 0755); err != nil { |
There was a problem hiding this comment.
Let's restrict the permissions to 0700, since we don't really want everyone on the machine reading our logs.
log/handler.go
Outdated
| // a new file named after the timestamp of the first log record it will contain. | ||
| func RotatingFileHandler(path string, limit uint, formatter Format) Handler { | ||
| if err := os.MkdirAll(path, 0755); err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
Let's return an error instead, panics can turn nasty if deep enough in the code. Same for all other panics too in this method btw.
log/handler.go
Outdated
| counter := new(writeCounter) | ||
| h := StreamHandler(counter, formatter) | ||
|
|
||
| re := regexp.MustCompile(".log$") |
dashboard/log.go
Outdated
| } | ||
| b := make([]byte, len(buf)+len(chunk)) | ||
| copy(b, buf) | ||
| copy(b[len(buf):], chunk) |
dashboard/log.go
Outdated
| var l *LogsMessage | ||
| // Update the history. | ||
| db.lock.Lock() | ||
| if len(db.history.Logs.Chunk) == 2 { |
dashboard/log.go
Outdated
| Past: false, | ||
| Last: true, | ||
| }, | ||
| Chunk: json.RawMessage("[]"), |
There was a problem hiding this comment.
separate it out as emptyChunk.
dashboard/assets/components/Logs.jsx
Outdated
| default: | ||
| lvl = ''; | ||
| } | ||
| if (lvl === '' || typeof t !== 'string' || t.length < 19 || typeof msg !== 'string' || !Array.isArray(ctx)) { |
There was a problem hiding this comment.
Let's use new Date(t) and handle any errors, cleaner than string manipulation.
dashboard/assets/components/Logs.jsx
Outdated
|
|
||
| for (let i = 0; i < ctx.length; i += 2) { | ||
| const key = ctx[i]; | ||
| const value = ctx[i + 1]; |
There was a problem hiding this comment.
nitpick, use val, same length as key.
karalabe
reviewed
Jun 28, 2018
dashboard/assets/components/Logs.jsx
Outdated
| padding = value.length; | ||
| fieldPadding.set(key, padding); | ||
| } | ||
| content += ` <span style="color:${color}">${key}</span>=${value}${' '.repeat(padding - value.length)}`; |
|
You need to vendor in the missing packages. Also, afaik we already have a file system notification package vendored in. Perhaps use that instead? |
|
You also need to |
kurkomisi
force-pushed
the
dashboard-logger
branch
from
ab025a5 to
64af3ef
Compare
karalabe
requested changes
Jul 9, 2018
There was a problem hiding this comment.
Something seems off, I'm getting errors in the logs when I load the page.
WARN [07-09|12:01:34.919] Failed to load the asset path=/service-worker-7c7a96ce6fa87adc81b6af59edceb61b59781902a923313485bf6f4d32a1fad3.js err="Asset service-worker-7c7a96ce6fa87adc81b6af59edceb61b59781902a923313485bf6f4d32a1fad3.js not found"
karalabe
approved these changes
Jul 11, 2018
firmianavan
pushed a commit
to firmianavan/go-ethereum
that referenced
this pull request
Aug 28, 2018
* cmd, dashboard, internal, log, node: logging feature * cmd, dashboard, internal, log: requested changes * dashboard, vendor: gofmt, govendor, use vendored file watcher * dashboard, log: gofmt -s -w, goimports * dashboard, log: gosimple
Closed
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 4, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 13, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 14, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 14, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 14, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 15, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 15, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 15, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an implementation of log saver and visualizer.