keystore, ethash, eth, miner, rpc, whisperv6: Addresses tech of now defunct vendored set. #16873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
deckarep
force-pushed
the
updating-vendored-set-lib
branch
from
ebbab0f to
d317e9b
Compare
|
I'll follow up on fixing the build issues...although I'm not yet clear why some of the builds are green and some are red. Will followup with a proper fix. |
firmianavan
pushed a commit
to firmianavan/go-ethereum
that referenced
this pull request
Aug 28, 2018
* keystore, ethash, eth, miner, rpc, whisperv6: tech debt with now defunct set. * whisperv5: swap out gopkg.in/fatih/set.v0 with supported set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some tech-debt by removing a set implementation that is no longer supported and has been archived on github: https://github.com/fatih/set
In favor of this well-supported and well-adopted version: https://github.com/deckarep/golang-set
This PR removes the now defunct: gopkg.in/fatih/set.v0 with a different but well-supported implementation and includes significantly more unit-tests and benchmarks.
This version has a slightly different API but is feature complete and supports both thread-safe and non-threadsafe implementations of a Set backed by an interface.
This alternative implementation is currently used in several high profile Go libraries. Notably: Docker and Kubernetes.