node: detect and fill counters as part of debug_api/metrics rpc #16054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
force-pushed
the
debugapi_metrics_fill_counters
branch
from
f46f698 to
9c5f8b3
Compare
|
I think counters were added fairly late and we didn't use the monitor for anything since then. All in all I think we should just kill the monitor. Noone's using it anyway since noone's maintaining it. Maybe the dashboard could replace it eventually :) |
prestonvanloon
pushed a commit
to prestonvanloon/go-ethereum
that referenced
this pull request
Apr 2, 2018
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #15933
I am not 100% sure this is the correct way to fix the problem, but all counters are listed as type string and default value "Unknown metric type" when returned by this RPC.
I am not sure how this ever worked, considering that we have many counters as part of the codebase - @karalabe were they ever displayed in the
geth monitor?