Skip to content

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Dec 30, 2017

Upstream code still broken with Go 1.10beta1: rjeczalik/notify#139, don't merge!

Go 1.10 changes a few types around CGO and pointers. This caused the filesystem notification package to fail building on macos:

# github.com/ethereum/go-ethereum/vendor/github.com/rjeczalik/notify
vendor/github.com/rjeczalik/notify/watcher_fsevents_cgo.go:51: cannot use nil as type _Ctype_CFAllocatorRef in argument to func literal
vendor/github.com/rjeczalik/notify/watcher_fsevents_cgo.go:162: cannot use nil as type _Ctype_CFAllocatorRef in argument to _Cfunc_CFStringCreateWithCStringNoCopy
vendor/github.com/rjeczalik/notify/watcher_fsevents_cgo.go:163: cannot use nil as type _Ctype_CFAllocatorRef in argument to func literal

The issue was known and already fixed upstream in rjeczalik/notify#136, this PR pulls in the latest code.

@fjl fjl merged commit d2533d0 into ethereum:master Jan 2, 2018
@karalabe
Copy link
Member Author

karalabe commented Jan 2, 2018 via email

@fjl
Copy link
Contributor

fjl commented Jan 2, 2018

I didn't see the first line, sorry. You even made it bold.

@karalabe
Copy link
Member Author

karalabe commented Jan 2, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants