Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: fix megacheck warnings #14917

Merged
merged 2 commits into from
Aug 8, 2017
Merged

crypto: fix megacheck warnings #14917

merged 2 commits into from
Aug 8, 2017

Conversation

egonelbre
Copy link
Contributor

megacheck warnings still left:

crypto\ecies\asn1.go:50:2: var shaScheme is unused (U1000)
crypto\ecies\asn1.go:52:2: var x963Scheme is unused (U1000)
crypto\ecies\asn1.go:90:2: var rawCurveP256 is unused (U1000)
crypto\ecies\asn1.go:91:2: var rawCurveP384 is unused (U1000)
crypto\ecies\asn1.go:92:2: var rawCurveP521 is unused (U1000)
crypto\ecies\asn1.go:95:6: func rawCurve is unused (U1000)
crypto\ecies\asn1.go:171:2: var oidSHA1 is unused (U1000)
crypto\ecies\asn1.go:172:2: var oidSHA224 is unused (U1000)
crypto\ecies\asn1.go:173:2: var oidSHA256 is unused (U1000)
crypto\ecies\asn1.go:174:2: var oidSHA384 is unused (U1000)
crypto\ecies\asn1.go:175:2: var oidSHA512 is unused (U1000)
crypto\ecies\asn1.go:178:6: func hashFromOID is unused (U1000)
crypto\ecies\asn1.go:194:6: func oidFromHash is unused (U1000)
crypto\ecies\asn1.go:212:2: var asnAlgoSHA1 is unused (U1000)
crypto\ecies\asn1.go:215:2: var asnAlgoSHA224 is unused (U1000)
crypto\ecies\asn1.go:218:2: var asnAlgoSHA256 is unused (U1000)
crypto\ecies\asn1.go:221:2: var asnAlgoSHA384 is unused (U1000)
crypto\ecies\asn1.go:224:2: var asnAlgoSHA512 is unused (U1000)
crypto\ecies\asn1.go:240:6: type asnECPKAlgorithms is unused (U1000)
crypto\ecies\asn1.go:245:5: var idEcPublicKey is unused (U1000)
crypto\ecies\asn1.go:248:6: func curveToRaw is unused (U1000)
crypto\ecies\asn1.go:262:6: func asnECPublicKeyType is unused (U1000)
crypto\ecies\asn1.go:283:5: var asnECDH is unused (U1000)
crypto\ecies\asn1.go:288:2: var dhSinglePass_stdDH_sha1kdf is unused (U1000)
crypto\ecies\asn1.go:336:5: var eciesRecommendedParameters is unused (U1000)
crypto\ecies\asn1.go:337:5: var eciesSpecifiedParameters is unused (U1000)

This is the same question, what to do with specification constants that are unused?

@fjl
Copy link
Contributor

fjl commented Aug 7, 2017

I'll delete asn1.go, we don't use it.

@egonelbre
Copy link
Contributor Author

Do the Marshal|Unmarhsal Public|Private have to be reimplemented or can they removed as well? If they can be removed then I can add commit that deletes asn1.go.

@karalabe karalabe merged commit 10ce8b0 into ethereum:master Aug 8, 2017
@karalabe karalabe added this to the 1.7.0 milestone Aug 8, 2017
@egonelbre egonelbre deleted the megacheck_crypto branch August 8, 2017 11:04
markya0616 pushed a commit to markya0616/go-ethereum that referenced this pull request Aug 17, 2017
* crypto: fix megacheck warnings

* crypto/ecies: remove ASN.1 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants