cmd: Added support for downloading to another DB instance #14785
Conversation
cmd/geth/chaincmd.go
Outdated
| return err | ||
| } | ||
| for dl.Synchronising() { | ||
| time.Sleep(1000) |
There was a problem hiding this comment.
That's 1000ns. Please add a unit, e.g. 1 * time.Microsecond. Maybe it should sleep longer, too.
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
Arachnid
force-pushed
the
downloaddb
branch
5 times, most recently
from
7187da9 to
eb9c445
Compare
| utils.DataDirFlag, | ||
| utils.CacheFlag, | ||
| utils.SyncModeFlag, | ||
| utils.FakePoWFlag, |
There was a problem hiding this comment.
I think we're going to need
utils.TestnetFlag,
utils.RinkebyFlag,
too to allow copying over the testnet chains.
cmd/geth/chaincmd.go
Outdated
| }, | ||
| Category: "BLOCKCHAIN COMMANDS", | ||
| Description: ` | ||
| The first argument must be the directory containing the blockchain to download from`, |
There was a problem hiding this comment.
From, or to? Aren't we downloading from the --datadir?
|
I've moved the localPeer into |
No description provided.