Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct subdirectory used for keys and use os.Remove instead of RemoveAll #443

Closed
Gustav-Simonsson opened this issue Mar 9, 2015 · 3 comments
Closed

Correct subdirectory used for keys and use os.Remove instead of RemoveAll #443

Gustav-Simonsson opened this issue Mar 9, 2015 · 3 comments

Comments

@Gustav-Simonsson
Copy link

The keys should be in a sub-directory in the datadir, and also usage of os.Remove instead of RemoveAll is better in case the key address is ever empty, to avoid accidentally deleting the whole (sub) directory.
@fjl
Copy link
Contributor

fjl commented Mar 13, 2015

The keys are now in <datadir>/keys.

@fjl fjl closed this as completed Mar 13, 2015
@Gustav-Simonsson
Copy link
Author

Re-opening since it still uses os.RemoveAll

@zelig zelig changed the title Correct subdirectory used for keys and use os.Remove insted of RemoveAll Correct subdirectory used for keys and use os.Remove instead of RemoveAll Apr 14, 2015
@zelig zelig mentioned this issue Apr 14, 2015
Closed
18 tasks
@zelig
Copy link
Contributor

zelig commented Apr 25, 2015

fixed in #796

@zelig zelig closed this as completed Apr 25, 2015
nolash pushed a commit to nolash/go-ethereum that referenced this issue Apr 30, 2018
@acud
swarm/api/http: removed deprecated PUT apis (ethereum#443)
876134d 
- removed deprecated PUT apis
ngtuna added a commit to ngtuna/tomochain that referenced this issue Feb 22, 2019
@ngtuna
Merge pull request ethereum#443 from thanhnguyennguyen/new-apis-for-g…
756aebd 
…etBlockSigners-getBlockFinality

adding 2 new apis: eth.getBlockSigners and eth.getBlockFinality
@AndreiShybin AndreiShybin mentioned this issue Nov 5, 2022
Open
@AndreiShybin AndreiShybin mentioned this issue Dec 26, 2022
Open
tanishqjasoria pushed a commit to tanishqjasoria/go-ethereum that referenced this issue Oct 31, 2023
@Thegaram
fix: do not overwrite correct L1 index on signer startup (ethereum#443)
69dd39a 
* fix signer worker

* add logs

* bump version

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fjl @Gustav-Simonsson @zelig