Skip to content

Commit

Permalink
accounts/abi: fix case of generated java functions (#18372)
Browse files Browse the repository at this point in the history
  • Loading branch information
gballet authored Jan 2, 2019
1 parent a4af734 commit 9bfd0b6
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions accounts/abi/bind/bind.go
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ func namedTypeJava(javaKind string, solKind abi.Type) string {
// methodNormalizer is a name transformer that modifies Solidity method names to
// conform to target language naming concentions.
var methodNormalizer = map[Lang]func(string) string{
LangGo: capitalise,
LangGo: abi.ToCamelCase,
LangJava: decapitalise,
}

Expand All @@ -392,10 +392,12 @@ func capitalise(input string) string {

// decapitalise makes a camel-case string which starts with a lower case character.
func decapitalise(input string) string {
// NOTE: This is the current behavior, it doesn't match the comment
// above and needs to be investigated.
return abi.ToCamelCase(input)
if len(input) == 0 {
return input
}

goForm := abi.ToCamelCase(input)
return strings.ToLower(goForm[:1]) + goForm[1:]
}

// structured checks whether a list of ABI data types has enough information to
Expand Down

0 comments on commit 9bfd0b6

Please sign in to comment.