Add EIP-7623 #966
Open
Add EIP-7623 #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@nerolation I rebased this pull request on the new |
SamWilsn
reviewed
Jun 19, 2024
src/ethereum/prague/fork.py
Outdated
| @@ -936,14 +948,19 @@ def calculate_intrinsic_cost(tx: Transaction) -> Uint: | |||
| ------- | |||
| verified : `ethereum.base_types.Uint` | |||
| The intrinsic cost of the transaction. | |||
| verified : `ethereum.base_types.Uint` | |||
There was a problem hiding this comment.
Suggested change
| verified : `ethereum.base_types.Uint` | |
| tokens_in_calldata : `ethereum.base_types.Uint` |
|
I think there are a few errors in there. Personally, I use |
MarekM25
suggested changes
Oct 1, 2024
Co-authored-by: Tanishq Jasoria <jasoriatanishq@gmail.com>
Co-authored-by: Tanishq Jasoria <jasoriatanishq@gmail.com>
Co-authored-by: Tanishq Jasoria <jasoriatanishq@gmail.com>
rkrasiuk
reviewed
Oct 3, 2024
rkrasiuk
reviewed
Oct 3, 2024
Comment on lines
+979
to
+981
| # Transactions with less gas used than the floor pay at the floor cost. | ||
| if gas_used < floor: | ||
| gas_used = floor |
There was a problem hiding this comment.
there is a risk here that sender's balance is less than the floor, because we did not charge the floor as part of the intrinsic gas
There was a problem hiding this comment.
We check against gas limit at the start and user always have enough balance to pay for the gas limit and floor < gas limit for the transaction
lgtm Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add EIP-7623: Increase Calldata Cost