Add EIP-7623 #966
Add EIP-7623 #966
Conversation
|
@nerolation I rebased this pull request on the new |
src/ethereum/prague/fork.py
Outdated
| ------- | ||
| verified : `ethereum.base_types.Uint` | ||
| The intrinsic cost of the transaction. | ||
| verified : `ethereum.base_types.Uint` |
There was a problem hiding this comment.
| verified : `ethereum.base_types.Uint` | |
| tokens_in_calldata : `ethereum.base_types.Uint` |
|
I think there are a few errors in there. Personally, I use |
Co-authored-by: Tanishq Jasoria <jasoriatanishq@gmail.com>
Co-authored-by: Tanishq Jasoria <jasoriatanishq@gmail.com>
Co-authored-by: Tanishq Jasoria <jasoriatanishq@gmail.com>
| # Transactions with less gas used than the floor pay at the floor cost. | ||
| if gas_used < floor: | ||
| gas_used = floor |
There was a problem hiding this comment.
there is a risk here that sender's balance is less than the floor, because we did not charge the floor as part of the intrinsic gas
There was a problem hiding this comment.
We check against gas limit at the start and user always have enough balance to pay for the gas limit and floor < gas limit for the transaction
lgtm Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
| # Transactions with less gas used than the floor pay at the floor cost. | ||
| floor = Uint(tokens_in_calldata * FLOOR_CALLDATA_COST + TX_BASE_COST) | ||
| if gas_used < floor: | ||
| gas_used = floor |
There was a problem hiding this comment.
I believe this correction should be applied after the gas refund is applied. Argumentation and spec clarification here: ethereum/EIPs#9227.
Add EIP-7623: Increase Calldata Cost