Skip to content

Conversation

@timbeiko
Copy link
Contributor

@timbeiko timbeiko commented Jan 5, 2023

Decided on ACD#152

Signed-off-by: Tim Beiko <t.beiko23@gmail.com>
@yperbasis
Copy link
Member

Shall we move them to Cancun CFI instead?

@timbeiko
Copy link
Contributor Author

timbeiko commented Jan 5, 2023

@shemnon asked the same thing in the R&D discord. Happy to make that change if Geth + Nethermind also +1 :-)

@holgerd77
Copy link
Contributor

Would also support moving to Cancun CFI, I guess this will help that the topic stays on the table in a sufficient manner and also helps to serve as a reminder to continuously evolve thoughts on the topic and have necessary in-between discussions and decisions so that we hopefully get to a consistent and holistic plan on this incuding some long-term thinking throughout the months without the need for some last-minute rush where things run the risk to fall under the table.

@timbeiko
Copy link
Contributor Author

Merged as-is because other changes are blocked on it. Added an agenda item about Cancun CFI to the next ACD (ethereum/pm#704) given we couldn't get everyone to agree async here.

@SamWilsn SamWilsn deleted the acd152 branch April 10, 2024 23:51
Carsons-Eels pushed a commit to Carsons-Eels/execution-specs that referenced this pull request Oct 16, 2025
…ainer kinds (ethereum#676)

* fix(tests): Fix invalid EOF container combos test

Make sure the case is invalid only for one reason.

* new(tests): Add more cases for invalid subcontainer kind combos

* new(tests): Add test for valid subcontainer kinds on a deeper nesting level

* new(tests): Add test for valid subcontainer kinds in a non-first code section

* Update changelog
danceratopz pushed a commit to danceratopz/execution-specs that referenced this pull request Oct 22, 2025
…ainer kinds (ethereum#676)

* fix(tests): Fix invalid EOF container combos test

Make sure the case is invalid only for one reason.

* new(tests): Add more cases for invalid subcontainer kind combos

* new(tests): Add test for valid subcontainer kinds on a deeper nesting level

* new(tests): Add test for valid subcontainer kinds in a non-first code section

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants