Repository navigation
fix(spec-specs): read blob gas fields from any parent header - #3845
Open
AhmethanKalenderoglu wants to merge 1 commit into
Open
AhmethanKalenderoglu wants to merge 1 commit into
AhmethanKalenderoglu wants to merge 1 commit into
Conversation
Contributor
Author
|
@spencer-tb could you take a look when you get a chance? It's a follow-up to #3352 for the bpo2 → amsterdam case. CI needs approval to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3840.
calculate_excess_blob_gasin amsterdam only read the blob gas fields if the parent was an amsterdam or bpo5 header, so with a bpo2 parent (BPO2ToAmsterdamAtTime15k) the excess blob gas was reset to 0. All the forks that can come before amsterdam have these fields, so the check is dropped. Same change in bogota to keep the two in sync.Added a test with bpo2 and bpo5 parents, the bpo2 case fails without the fix.