Repository navigation
bug(test-eest): reconfigure output streams to UTF-8 on Windows consoles - #3209
Merged
marioevz merged 1 commit intoJul 27, 2026
Conversation
The `eest` commands print Unicode characters (box drawing in `info`, emoji in `clean` and `make`) via `click.echo`. On a Windows console using a legacy code page such as `cp1252`, these characters cannot be encoded and the command aborts with `UnicodeEncodeError`. Reconfigure `sys.stdout`/`sys.stderr` to UTF-8 in the `eest` group callback, guarded so streams that do not support reconfiguration (for example captured output under tests) are left untouched. Add regression tests covering a legacy-encoded stdout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
marioevz
approved these changes
Jul 27, 2026
marioevz
left a comment
marioevz
left a comment
Member
There was a problem hiding this comment.
Nice! Thanks for this fix.
cc @danceratopz I think it would be nice for us to enable a weekly windows run so we can keep the support for the platform, not urgent but wdyt?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3209 +/- ##
==================================================
Coverage ? 93.39%
==================================================
Files ? 624
Lines ? 37014
Branches ? 3386
==================================================
Hits ? 34570
Misses ? 1671
Partials ? 773
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
eestcommands print Unicode characters (box drawing ininfo, emoji incleanandmake) viaclick.echo. On a Windows console using a legacy code page such ascp1252, these characters cannot be encoded and the command aborts withUnicodeEncodeError.Reconfigure
sys.stdout/sys.stderrto UTF-8 in theeestgroup callback, guarded so streams that do not support reconfiguration (for example captured output under tests) are left untouched. Add regression tests covering a legacy-encoded stdout.Description
Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture