-
Notifications
You must be signed in to change notification settings - Fork 415
feat(tests): Add BAL tests that dequeue consolidations #2076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): Add BAL tests that dequeue consolidations #2076
Conversation
5353e65 to
ed6a768
Compare
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2076 +/- ##
================================================
Coverage 86.14% 86.14%
================================================
Files 599 599
Lines 39472 39472
Branches 3780 3780
================================================
Hits 34002 34002
Misses 4848 4848
Partials 622 622
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. π New features to boost your workflow:
|
| REFERENCE_SPEC_GIT_PATH = ref_spec_7251.git_path | ||
| REFERENCE_SPEC_VERSION = ref_spec_7251.version | ||
|
|
||
| pytestmark = pytest.mark.valid_from("Prague") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amsterdam
ed6a768 to
e993302
Compare
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
For future EIPs that introduce system contracts I think we will want to embed BAL verification in the conftest.py of the EIP directly, e.g https://github.com/ethereum/execution-specs/blob/forks/amsterdam/tests/prague/eip7251_consolidations/conftest.py for EIP-7251, but for these EIPs of prior forks I think this is ok.
fselmo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was just reviewing this as well. lgtm ππΌ
ποΈ Description
Add BAL tests that dequeue consolidations.
π Related Issues or PRs
#1878
β Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.