Skip to content

Conversation

@gurukamath
Copy link
Contributor

πŸ—’οΈ Description

Add BAL tests that dequeue consolidations.

πŸ”— Related Issues or PRs

#1878

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.

@gurukamath gurukamath requested a review from fselmo January 26, 2026 12:10
@gurukamath gurukamath force-pushed the eip-7928/include-7251-requests branch from 5353e65 to ed6a768 Compare January 26, 2026 12:45
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 86.14%. Comparing base (c3813a5) to head (e993302).
⚠️ Report is 2 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2076   +/-   ##
================================================
  Coverage            86.14%   86.14%           
================================================
  Files                  599      599           
  Lines                39472    39472           
  Branches              3780     3780           
================================================
  Hits                 34002    34002           
  Misses                4848     4848           
  Partials               622      622           
Flag Coverage Ξ”
unittests 86.14% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

REFERENCE_SPEC_GIT_PATH = ref_spec_7251.git_path
REFERENCE_SPEC_VERSION = ref_spec_7251.version

pytestmark = pytest.mark.valid_from("Prague")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amsterdam

@gurukamath gurukamath force-pushed the eip-7928/include-7251-requests branch from ed6a768 to e993302 Compare January 26, 2026 20:11
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

For future EIPs that introduce system contracts I think we will want to embed BAL verification in the conftest.py of the EIP directly, e.g https://github.com/ethereum/execution-specs/blob/forks/amsterdam/tests/prague/eip7251_consolidations/conftest.py for EIP-7251, but for these EIPs of prior forks I think this is ok.

Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just reviewing this as well. lgtm πŸ‘πŸΌ

@marioevz marioevz merged commit c6c380a into ethereum:forks/amsterdam Jan 26, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants