Skip to content

Conversation

@fselmo
Copy link
Contributor

@fselmo fselmo commented Jan 22, 2026

🗒️ Description

#2023 backported some changes but it would be good to get them into the development fork and bubble them back up through a rebase into the eips branches. This brings the changes merging execute_code logic with process_message into the development fork to be rebased back into the eips/amsterdam/... branches.

  • Cherry-picked original commit
  • Added support to all forks in subsequent commit

Based on original comment #2023 (comment)

🔗 Related Issues or PRs

#2023, commit 7495813

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

@fselmo fselmo changed the title Refactor/execute code into process message refactor(spec): refactor execute_code into process_message Jan 22, 2026
@fselmo fselmo added A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) C-refactor Category: refactor labels Jan 22, 2026
- Align changes to process_message after cherry-pick
- Add changes to missing forks
@fselmo fselmo force-pushed the refactor/execute_code-into-process_message branch from f2278d2 to b256fbb Compare January 22, 2026 15:24
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.14%. Comparing base (3b9b018) to head (b256fbb).
⚠️ Report is 1 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #2061      +/-   ##
===================================================
- Coverage            86.16%   86.14%   -0.02%     
===================================================
  Files                  599      599              
  Lines                39527    39472      -55     
  Branches              3780     3780              
===================================================
- Hits                 34059    34004      -55     
  Misses                4847     4847              
  Partials               621      621              
Flag Coverage Δ
unittests 86.14% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Logic seems to be exactly the same in all forks. Thanks for this!

@fselmo fselmo merged commit 31defc8 into ethereum:forks/amsterdam Jan 22, 2026
17 checks passed
@fselmo fselmo deleted the refactor/execute_code-into-process_message branch January 22, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) C-refactor Category: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants