Skip to content

Conversation

@danceratopz
Copy link
Member

@danceratopz danceratopz commented Jan 19, 2026

🗒️ Description

Add all EL clients to the hive master config for CI testing.

Tested builds in hive:

./hive --sim ethereum/eels/consume-rlp --client besu,erigon,ethrex,go-ethereum,nethermind,nimbus-el,reth --client-file ../execution-specs/.github/configs/hive/master.yaml --sim.limit="id:tests/istanbul/eip1344_chainid/test_chainid.py::test_chainid[fork_Osaka-typed_transaction_2-blockchain_test_from_state_test]" --sim.buildarg "fixtures=develop@v5.3.0"

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails
  • All: PR title adheres to the repo standard
image

@danceratopz danceratopz force-pushed the chore/add-client-master-hive-config branch from b77a40d to d004a42 Compare January 19, 2026 08:56
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (1d11d8d) to head (d004a42).
⚠️ Report is 2 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2034   +/-   ##
================================================
  Coverage            86.07%   86.07%           
================================================
  Files                  599      599           
  Lines                39527    39527           
  Branches              3780     3780           
================================================
  Hits                 34021    34021           
  Misses                4872     4872           
  Partials               634      634           
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding these.

@spencer-tb spencer-tb added C-chore Category: chore A-ci Area: Continuous Integration labels Jan 19, 2026
@spencer-tb spencer-tb merged commit acd8d6c into ethereum:forks/amsterdam Jan 19, 2026
20 checks passed
jsign pushed a commit to jsign/execution-specs that referenced this pull request Jan 20, 2026
* refactor(eip7825): update legacy configuration

* tests(eip7825): add extra cases for tx gas limit

* test(eip7825): add extra case for access list

* refactor: update test logic
jsign pushed a commit to jsign/execution-specs that referenced this pull request Jan 20, 2026
* refactor(eip7825): update legacy configuration

* tests(eip7825): add extra cases for tx gas limit

* test(eip7825): add extra case for access list

* refactor: update test logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: Continuous Integration C-chore Category: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants