Skip to content

Conversation

@raxhvl
Copy link
Member

@raxhvl raxhvl commented Jan 8, 2026

🗒️ Description

The PR implements tests discussed in #1953

✅ Checklist

Cute Animal Picture

               __
              / _)
     _.----._/ /
    /         /
 __/ (  | (  |
/__.-'|_|--|_|

@raxhvl
Copy link
Member Author

raxhvl commented Jan 8, 2026

@fselmo The tests covers what we discussed, let me know if we need any additional coverage.

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (eips/amsterdam/eip-7928@6b6d078). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             eips/amsterdam/eip-7928    #1992   +/-   ##
==========================================================
  Coverage                           ?   86.25%           
==========================================================
  Files                              ?      538           
  Lines                              ?    34561           
  Branches                           ?     3224           
==========================================================
  Hits                               ?    29809           
  Misses                             ?     4165           
  Partials                           ?      587           
Flag Coverage Δ
unittests 86.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice additions, thanks! 👌🏼

@fselmo fselmo merged commit d8b5dad into ethereum:eips/amsterdam/eip-7928 Jan 8, 2026
14 checks passed
fselmo added a commit to fselmo/execution-specs that referenced this pull request Jan 12, 2026
* 🧪 test(EIP-7928): test_bal_invalid_extraneous_entries

* 🥢 nit:

* chore: fix lint issues

---------

Co-authored-by: raxhvl <raxhvl@users.noreply.github.com>
Co-authored-by: fselmo <fselmo2@gmail.com>
fselmo added a commit to fselmo/execution-specs that referenced this pull request Jan 12, 2026
* 🧪 test(EIP-7928): test_bal_invalid_extraneous_entries

* 🥢 nit:

* chore: fix lint issues

---------

Co-authored-by: raxhvl <raxhvl@users.noreply.github.com>
Co-authored-by: fselmo <fselmo2@gmail.com>
fselmo added a commit that referenced this pull request Jan 12, 2026
* 🧪 test(EIP-7928): test_bal_invalid_extraneous_entries

* 🥢 nit:

* chore: fix lint issues

---------

Co-authored-by: raxhvl <raxhvl@users.noreply.github.com>
Co-authored-by: fselmo <fselmo2@gmail.com>
fselmo added a commit to fselmo/execution-specs that referenced this pull request Jan 15, 2026
* 🧪 test(EIP-7928): test_bal_invalid_extraneous_entries

* 🥢 nit:

* chore: fix lint issues

---------

Co-authored-by: raxhvl <raxhvl@users.noreply.github.com>
Co-authored-by: fselmo <fselmo2@gmail.com>
fselmo added a commit to fselmo/execution-specs that referenced this pull request Jan 15, 2026
* 🧪 test(EIP-7928): test_bal_invalid_extraneous_entries

* 🥢 nit:

* chore: fix lint issues

---------

Co-authored-by: raxhvl <raxhvl@users.noreply.github.com>
Co-authored-by: fselmo <fselmo2@gmail.com>
fselmo added a commit that referenced this pull request Jan 16, 2026
* 🧪 test(EIP-7928): test_bal_invalid_extraneous_entries

* 🥢 nit:

* chore: fix lint issues

---------

Co-authored-by: raxhvl <raxhvl@users.noreply.github.com>
Co-authored-by: fselmo <fselmo2@gmail.com>
jsign pushed a commit to jsign/execution-specs that referenced this pull request Jan 20, 2026
* refactor: update comment

* tests: add extra modexp cases

* test: add extra ecpairing cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants