chore(spec-tests): fix typos in tests/
#1968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed ~69 files in tests/prague directory for grammar issues. No grammar issues found. All docstrings, comments, and string messages are grammatically correct. Marked tests/prague/**/*.py as complete in the grammar check checklist. Co-authored-by: Claude <noreply@anthropic.com>
* chore(docs): fix grammar and spelling in tests/frontier/**/*.py
Fix various grammar and spelling issues across 14 test files:
- Capitalize module docstrings ("test X" -> "Test X")
- Fix possessive "it's" -> "its" in 4 locations
- Fix "Weather" -> "Whether" spelling error
- Fix redundant words ("fork supports" -> "fork")
- Fix incomplete sentences and add missing periods
- Fix subject-verb agreement ("stack underflow" -> "stack underflows")
- Remove duplicate words ("Test DUP Test" -> "Test")
* Update tests/frontier/scenarios/programs/all_frontier_opcodes.py
---------
Co-authored-by: Claude <noreply@anthropic.com>
* docs: fix grammar in tests/frontier/**/*.py Fix grammar issues in module and function docstrings: - test_create_deposit_oog.py: Fix module docstring grammar - test_create_one_byte.py: Fix run-on sentence and verb forms - test_create_suicide_store.py: Fix missing article and verb agreement - scenarios/common.py: Fix missing periods and capitalization - validation/test_header.py: Fix incomplete phrase - validation/test_transaction.py: Fix awkward phrasing * Update tests/frontier/create/test_create_suicide_store.py --------- Co-authored-by: Claude <noreply@anthropic.com>
Fix "there for" -> "therefore" typo in a comment in test_tload_calls.py Co-authored-by: Claude <noreply@anthropic.com>
Remove extraneous leading space from module docstring in test_blob_reserve_price_with_bpo.py. Co-authored-by: Claude <noreply@anthropic.com>
Fix minor grammar and spelling issues in benchmark test files: - helpers.py: Add missing word "how" in docstring - test_log.py: Fix incomplete comment with missing word "data" - test_account_query.py: Fix incomplete sentence in docstring Co-authored-by: Claude <noreply@anthropic.com>
Fix typo "teansition" -> "transition" in load_blockchain_tests.py Co-authored-by: Claude <noreply@anthropic.com>
Fix incomplete sentence in TestMultipleWithdrawalsSameAddress docstring. The sentence "Test that multiple withdrawals can be sent to the same address in." was missing proper structure. Rewrote following the pattern used by TestUseValueInTx with self-contained summary and description. Co-authored-by: Claude <noreply@anthropic.com>
Fix inaccurate docstrings in test_gas.py files that incorrectly listed precompiles not actually tested by each file. Co-authored-by: Claude <noreply@anthropic.com>
Fix grammar issues in docstrings: - test_blake2_delegatecall.py: "before and after added" -> "before and after being added" - test_precompile_warming.py: "a precompile addresses" -> "precompile addresses" Co-authored-by: Claude <noreply@anthropic.com>
- Fix subject-verb disagreement and missing period in spec.py - Fix "pre existing" -> "pre-existing" in test_block_access_lists_eip7702.py - Fix missing "be" in "expect the account to non-existent" in test_block_access_lists.py - Rewrite unclear module docstring in test_create_returndata.py Co-authored-by: Claude <noreply@anthropic.com>
Reviewed 17 files across tests/london/**/*.py, tests/homestead/**/*.py, and tests/paris/**/*.py for grammar issues. No corrections needed - all docstrings, comments, and string messages are grammatically correct. Co-authored-by: Claude <noreply@anthropic.com>
- "can help creating" → "can help create" - "in forks pre Byzantium" → "in pre-Byzantium forks" Co-authored-by: Claude <noreply@anthropic.com>
Corrected copy-paste errors from EIP-6110 deposits tests: - EIP-7002: "deposit tests" -> "withdrawal tests" - EIP-7251: "deposit transaction" -> "consolidation request" - EIP-7685: "deposit tests" -> "request tests" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Changed "Note: Adding a new test Add a function" to "Note: To add a new test, add a function" for proper grammar. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Removed duplicate "error error" -> "error" in test_excess_blob_gas_fork_transition.py. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Added missing article "a" before "block" in spec.py comment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Moved implementation comment into docstring, fixing punctuation and formatting issues in the process: - `Transfer`` -> `Transfer` - `True`` -> `True` - Added proper sentence structure 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
danceratopz
added
A-doc
Collaborator
|
I love using AI like this. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #1968 +/- ##
================================================
Coverage 86.33% 86.33%
================================================
Files 538 538
Lines 34557 34557
Branches 3222 3222
================================================
Hits 29835 29835
Misses 4148 4148
Partials 574 574
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
felix314159
approved these changes
Jan 7, 2026
Contributor
felix314159
left a comment
felix314159
left a comment
There was a problem hiding this comment.
Thanks, good changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Fix spelling and grammar errors in Python docstrings and comments under
./tests/.This was performed semi-automatically with Claude. I have reviewed all changes (but happy for a cross-check), most of them, as part of the following PRs:
🔗 Related Issues or PRs
src/ethereum/#1965✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.All: Considered adding an entry to CHANGELOG.md.Cute Animal Picture