-
Notifications
You must be signed in to change notification settings - Fork 414
feat(specs): EIP-7928 move bal from payload #1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): EIP-7928 move bal from payload #1917
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7928 #1917 +/- ##
==========================================================
Coverage ? 86.25%
==========================================================
Files ? 538
Lines ? 34561
Branches ? 3224
==========================================================
Hits ? 29809
Misses ? 4165
Partials ? 587
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6967b93 to
be73122
Compare
340bee1 to
211f899
Compare
be73122 to
ba0eec1
Compare
211f899 to
858d7c3
Compare
fselmo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm, thank you!
2344445
into
ethereum:eips/amsterdam/eip-7928
* feat(specs): EIP-7928 move bal from payload * remove BAL from stf * fix linter
* feat(specs): EIP-7928 move bal from payload * remove BAL from stf * fix linter
* feat(specs): EIP-7928 move bal from payload * remove BAL from stf * fix linter
* feat(specs): EIP-7928 move bal from payload * remove BAL from stf * fix linter
* feat(specs): EIP-7928 move bal from payload * remove BAL from stf * fix linter
* feat(specs): EIP-7928 move bal from payload * remove BAL from stf * fix linter
🗒️ Description
This PR completes the EIP-7928 block access list (BAL) refactoring by moving BAL validation outside of the state transition function.
The changes across the last two commits:
The state transition now:
This simplifies the state transition by removing the need to pass and validate the full BAL, since the actual BAL validation (checking p2p received BAL matches the hash) is handled at the engine API layer.
🔗 Related Issues or PRs
N/A.