Skip to content

Conversation

@fselmo
Copy link
Contributor

@fselmo fselmo commented Dec 12, 2025

🗒️ Description

  • Change storage slots to use U256 instead of Bytes32: related change in EIP-7928 here
  • Rename tx_index -> block_access_index across the testing framework

For ease of review, most changes related to the types changes are in builder.py, rlp_types.py, t8n_types.py, and in the testing framework side within packages/testing/src/execution_testing/test_types/block_access_list/account_changes.py

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Screenshot 2025-12-12 at 11 59 33

@fselmo fselmo added A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) C-feat Category: an improvement or new feature labels Dec 12, 2025
@fselmo fselmo force-pushed the feat/update-eip7928-to-latest-rlp-specs branch 2 times, most recently from c26d85f to 96d0867 Compare December 12, 2025 18:47
@fselmo fselmo force-pushed the feat/update-eip7928-to-latest-rlp-specs branch from 96d0867 to e17aa53 Compare December 12, 2025 18:50
@fselmo fselmo marked this pull request as ready for review December 12, 2025 18:50
@fselmo fselmo merged commit 9ab51f2 into ethereum:eips/amsterdam/eip-7928 Dec 12, 2025
11 of 13 checks passed
@fselmo fselmo deleted the feat/update-eip7928-to-latest-rlp-specs branch December 12, 2025 19:20
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (eips/amsterdam/eip-7928@69e09f0). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             eips/amsterdam/eip-7928    #1912   +/-   ##
==========================================================
  Coverage                           ?   83.85%           
==========================================================
  Files                              ?      402           
  Lines                              ?    25105           
  Branches                           ?     2287           
==========================================================
  Hits                               ?    21051           
  Misses                             ?     3615           
  Partials                           ?      439           
Flag Coverage Δ
unittests 83.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fselmo added a commit that referenced this pull request Dec 15, 2025
…_index (#1912)

* feat(spec-test): Change storage RLP encoding to U256; tx_index rename

* fix: unit tests exception message
fselmo added a commit that referenced this pull request Dec 17, 2025
…_index (#1912)

* feat(spec-test): Change storage RLP encoding to U256; tx_index rename

* fix: unit tests exception message
Carsons-Eels pushed a commit to Carsons-Eels/execution-specs that referenced this pull request Jan 6, 2026
* feat(filler): Add unit test to verify pre-alloc grouping on different state test envs

* fix(specs): Genesis generation for state tests
fselmo added a commit to fselmo/execution-specs that referenced this pull request Jan 12, 2026
…_index (ethereum#1912)

* feat(spec-test): Change storage RLP encoding to U256; tx_index rename

* fix: unit tests exception message
fselmo added a commit to fselmo/execution-specs that referenced this pull request Jan 12, 2026
…_index (ethereum#1912)

* feat(spec-test): Change storage RLP encoding to U256; tx_index rename

* fix: unit tests exception message
fselmo added a commit that referenced this pull request Jan 12, 2026
…_index (#1912)

* feat(spec-test): Change storage RLP encoding to U256; tx_index rename

* fix: unit tests exception message
fselmo added a commit to fselmo/execution-specs that referenced this pull request Jan 15, 2026
…_index (ethereum#1912)

* feat(spec-test): Change storage RLP encoding to U256; tx_index rename

* fix: unit tests exception message
fselmo added a commit to fselmo/execution-specs that referenced this pull request Jan 15, 2026
…_index (ethereum#1912)

* feat(spec-test): Change storage RLP encoding to U256; tx_index rename

* fix: unit tests exception message
fselmo added a commit that referenced this pull request Jan 16, 2026
…_index (#1912)

* feat(spec-test): Change storage RLP encoding to U256; tx_index rename

* fix: unit tests exception message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants