-
Notifications
You must be signed in to change notification settings - Fork 414
feat(tests): add more 7928 test descriptions #1815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…1815) * chore(consume): add exponential retry logic for initial fcu in consume engine. * chore(docs): changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, took me a minute to review and merge some PRs ahead of this one... sorry for the wait here! I just merged those and rebased this one. We may have a duplicate case, can you make sure?
ebc749e to
6044b67
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7928 #1815 +/- ##
===========================================================
- Coverage 86.32% 86.25% -0.08%
===========================================================
Files 538 538
Lines 34561 34561
Branches 3224 3224
===========================================================
- Hits 29835 29809 -26
- Misses 4152 4165 +13
- Partials 574 587 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @fselmo ! |
All I've done is rebase here so that it didn't have conflicts. If you agree that it's testing the same case then we still need to remove it from this list and then merge the other two cases in this PR. What do you think? |
* chore(consume): add exponential retry logic for initial fcu in consume engine. * chore(docs): changelog.
|
looks good! |
be73122 to
ba0eec1
Compare
* feat(tests): add more 7928 test descriptions * chore(test): remove test duplicated by test_bal_create_selfdestruct_to_self_with_call --------- Co-authored-by: fselmo <fselmo2@gmail.com>
* feat(tests): add more 7928 test descriptions * chore(test): remove test duplicated by test_bal_create_selfdestruct_to_self_with_call --------- Co-authored-by: fselmo <fselmo2@gmail.com>
* feat(tests): add more 7928 test descriptions * chore(test): remove test duplicated by test_bal_create_selfdestruct_to_self_with_call --------- Co-authored-by: fselmo <fselmo2@gmail.com>
* feat(tests): add more 7928 test descriptions * chore(test): remove test duplicated by test_bal_create_selfdestruct_to_self_with_call --------- Co-authored-by: fselmo <fselmo2@gmail.com>
* feat(tests): add more 7928 test descriptions * chore(test): remove test duplicated by test_bal_create_selfdestruct_to_self_with_call --------- Co-authored-by: fselmo <fselmo2@gmail.com>
* feat(tests): add more 7928 test descriptions * chore(test): remove test duplicated by test_bal_create_selfdestruct_to_self_with_call --------- Co-authored-by: fselmo <fselmo2@gmail.com>
🗒️ Description
This PR adds three new BAL edge-case tests covering 7702 multi-authorization behavior and the two distinct post-Cancún SELFDESTRUCT outcomes:
7702 Double Authorization Reset:
A single transaction includes two EIP-7702 authorizations for
Alice—first setting delegation code, then clearing it.BAL must reflect the correct nonce increments (self-funded: 0→3; sponsored: 0→2) and must not include any
code_changes, since the final code is empty.SELFDESTRUCT Sending Funds Back to Sender:
A pre-existing contract
CexecutesSELFDESTRUCT(Alice).Under EIP-6780,
Cremains intact (no code deletion) and all its balance is transferred toAlice.BAL must show
C’s balance going to zero andAlicereceiving the value.SELFDESTRUCT That Burns ETH (Created and Destroyed in Same Tx):
A contract
Dis created and, in the same transaction, executesSELFDESTRUCT(D).Per EIP-6780, the ETH is burned rather than transferred.
BAL must show
D’s balance reduced to zero with no beneficiary receiving the value.