Skip to content

Conversation

@gurukamath
Copy link
Contributor

What was wrong?

The path prefix in the patch tool is outdated after all the fork related spec code was moved into the forks folder.

How was it fixed?
Add the forks folder to the path prefix.

@gurukamath gurukamath changed the title fix(tool): update path to include forks folder bug(tool): update path to include forks folder Sep 23, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (5ddb904) to head (5b5a47b).
⚠️ Report is 1 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           forks/osaka    #1436   +/-   ##
============================================
  Coverage        86.07%   86.07%           
============================================
  Files              743      743           
  Lines            44072    44072           
  Branches          3891     3891           
============================================
  Hits             37936    37936           
  Misses            5659     5659           
  Partials           477      477           
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth looking at #1372

@SamWilsn SamWilsn merged commit 8680760 into ethereum:forks/osaka Sep 25, 2025
12 of 13 checks passed
Carsons-Eels pushed a commit to Carsons-Eels/execution-specs that referenced this pull request Oct 16, 2025
* feat(specs): Introduce/enforce `negative` marker

* feat(tests): Add marker to all invalid transaction/block tests

* changelog

* refactor(specs): Rename marker to `pytest.mark.exception_test`

* refactor(tests): Rename marker to `pytest.mark.exception_test`

* refactor(specs): Make `request` a `PrivateAttr`

* nit

* fix(specs): Review suggestions

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>

---------

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
danceratopz pushed a commit to danceratopz/execution-specs that referenced this pull request Oct 22, 2025
* feat(specs): Introduce/enforce `negative` marker

* feat(tests): Add marker to all invalid transaction/block tests

* changelog

* refactor(specs): Rename marker to `pytest.mark.exception_test`

* refactor(tests): Rename marker to `pytest.mark.exception_test`

* refactor(specs): Make `request` a `PrivateAttr`

* nit

* fix(specs): Review suggestions

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>

---------

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
Carsons-Eels pushed a commit to Carsons-Eels/execution-specs that referenced this pull request Jan 6, 2026
* feat(specs): Introduce/enforce `negative` marker

* feat(tests): Add marker to all invalid transaction/block tests

* changelog

* refactor(specs): Rename marker to `pytest.mark.exception_test`

* refactor(tests): Rename marker to `pytest.mark.exception_test`

* refactor(specs): Make `request` a `PrivateAttr`

* nit

* fix(specs): Review suggestions

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>

---------

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
Carsons-Eels pushed a commit to Carsons-Eels/execution-specs that referenced this pull request Jan 6, 2026
* feat(specs): Introduce/enforce `negative` marker

* feat(tests): Add marker to all invalid transaction/block tests

* changelog

* refactor(specs): Rename marker to `pytest.mark.exception_test`

* refactor(tests): Rename marker to `pytest.mark.exception_test`

* refactor(specs): Make `request` a `PrivateAttr`

* nit

* fix(specs): Review suggestions

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>

---------

Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants