bugfix(Osaka): TARGET_BLOB_GAS_PER_BLOCK should not be an independent constant #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurukamath
force-pushed
the
blob-gas-constant
branch
from
97be944 to
d32cac1
Compare
souradeep-das
approved these changes
Aug 15, 2025
gurukamath
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1370 +/- ##
============================================
Coverage 94.26% 94.26%
============================================
Files 583 583
Lines 34666 34666
Branches 3070 3070
============================================
Hits 32677 32677
Misses 1454 1454
Partials 535 535
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SamWilsn
approved these changes
Aug 18, 2025
danceratopz
pushed a commit
to danceratopz/execution-specs
that referenced
this pull request
Oct 22, 2025
…#1370) * refactor(versioning): optimize git tag lookup and URL generation * Update versioning.py * Update src/ethereum_test_tools/utility/versioning.py Co-authored-by: spencer <spencer.taylor-brown@ethereum.org> * fix lint * Update versioning.py * Update versioning.py --------- Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
Carsons-Eels
pushed a commit
to Carsons-Eels/execution-specs
that referenced
this pull request
Jan 6, 2026
…#1370) * refactor(versioning): optimize git tag lookup and URL generation * Update versioning.py * Update src/ethereum_test_tools/utility/versioning.py Co-authored-by: spencer <spencer.taylor-brown@ethereum.org> * fix lint * Update versioning.py * Update versioning.py --------- Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
TARGET_BLOB_GAS_PER_BLOCK should be GAS_PER_BLOB * BLOB_SCHEDULE_TARGET. Having GAS_PER_BLOB and BLOB_SCHEDULE_TARGET as well as TARGET_BLOB_GAS_PER_BLOCK as independently defined constants creates 2 sources of truth and room for potential bugs
Related to Issue #1369
How was it fixed?
Define
TARGET_BLOB_GAS_PER_BLOCKasGAS_PER_BLOB * BLOB_SCHEDULE_TARGETCute Animal Picture