Skip to content

Implement check for fixtures version #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Antrikshgwal
Copy link
Contributor

@Antrikshgwal Antrikshgwal commented Mar 20, 2025

What was wrong?

download_fixtures method doesn't check for fixture version and re-downloads fixtures even when the same version already exists on the location.

Related to Issue #728

How was it fixed?

Implemented a mechanism that stores the URL while downloading fixtures and compares it with the URL used on subsequent function calls. Since the URL changes on a version change, we can know if the version has been changed and if we need to re-download the fixtures. Otherwise, we can skip the download.

Cute Animal Picture

image

@SamWilsn
Copy link
Contributor

In 8f3ffd3f0d I updated the fixture fetcher to cache downloaded files. Do you think the optimization you have here is still worth it, and if so, would you be interested in rebasing it or should I?

@Antrikshgwal
Copy link
Contributor Author

In 8f3ffd3f0d I updated the fixture fetcher to cache downloaded files. Do you think the optimization you have here is still worth it, and if so, would you be interested in rebasing it or should I?

I think 8f3ffd3f0d is a more robust approach while still optimising the fixture fetching. So, it would be a better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants