Zero test for Tangerine Whistle / Spurious Dragon / Constantinople

[chfast]

Non of the test is generated for these 3 forks (even for tests targeting Frontier):

• Tangerine Whistle
• Spurious Dragon
• Constantinople

[fselmo]

@chfast that's correct, they are currently ignored. Constantinople is a bit different in that some places in our codebase say it is not supported by EELS, so marked in UNSUPPORTED_FORKS... but it looks like it is supported by EELS 🤔.

Would have to get someone else with more context to answer why these are ignored... but perhaps the Constantinople reasoning is stale here? cc: @gurukamath @marioevz

[gurukamath]

Would have to get someone else with more context to answer why these are ignored... but perhaps the Constantinople reasoning is stale here? cc: @gurukamath @marioevz

EELS t8n supports ConstantinopleFix but not Constantinople. IIRC, this confusing naming is a hangover from ethereum/tests. In the ethereum/tests repo Constantinople is essentially the originally planned Petersburg fork which never hit mainnet.

[chfast]

Yes, the Constantinople is dead fork because it never hit the Mainnet and there is no any testet with it left.

I think I can just remove it on my side. But what with legacy tests?

[jochem-brouwer]

Suggestion: per EIPs the correct naming of the fork ConstantinopleFix is Petersburg: https://eips.ethereum.org/EIPS/eip-1716. So I would suggest to rename ConstantinopleFix to Petersburg.

For EELS to support Constantinople it would require EIP-1283 implementation. But to do so correctly we would need another client to test it against (to verify EELS implementation is correct). I think Geth still supports Constantinople as the way a problem with EIP-1283 was solved (by removing it from the fork) by creating a new fork (Petersburg) which is the fork after Constantinople in the clients back then. The fork block of these two forks are thus equal.

See: https://github.com/ethereum/go-ethereum/blob/bbb1ab8d16f2cf83fdc1bd63acb6af87dc52ef7f/params/config.go#L52

It also seems that EELS Constantinople fork is in fact Petersburg, because this does not look like EIP-1283 logic:

execution-specs/src/ethereum/forks/constantinople/vm/instructions/storage.py

Lines 71 to 82 in 402b3d0

	# GAS
	state = evm.message.block_env.state
	current_value = get_storage(state, evm.message.current_target, key)
	if new_value != 0 and current_value == 0:
	gas_cost = GAS_STORAGE_SET
	else:
	gas_cost = GAS_STORAGE_UPDATE
	if new_value == 0 and current_value != 0:
	evm.refund_counter += int(GAS_STORAGE_CLEAR_REFUND)
	charge_gas(evm, gas_cost)

[chfast]

Let's kill Constantinople. I don't think it is worth maintaining it just for historical purposes. @MariusVanDerWijden ?