Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EIP-7702: Set code of non-empty-storage account #948

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Nov 7, 2024

🗒️ Description

Simple test to verify that the code can be set for an account with a non-empty storage (In case account delegated previously, set some storage value, then reset its delegation to empty).

Also fixes the pre.fund_eoa method to consider the extra nonce bump that would realistically be required if an account removed its delegation.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tests Scope: Test cases type:test Type: Test scope:fw Scope: Framework (evm|tools|forks|pytest) labels Nov 7, 2024
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spencer-tb spencer-tb merged commit bf46ecd into main Nov 8, 2024
5 checks passed
@spencer-tb spencer-tb deleted the eip-7702-set-code-to-not-empty-storage branch November 8, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tests Scope: Test cases type:test Type: Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants